yiisoft / yii2-docker

Official Docker images suitable for Yii 2.0
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
381 stars 202 forks source link

build images for amd64 and arm64 platform (for Apple Silicon, M1, M2) #161

Closed albertborsos closed 1 year ago

albertborsos commented 1 year ago

resolves #129 resolves #148

I tested it on Docker Hub, you can try the built images with: albertborsos/yii2-php:8.0-apache

Images on Docker Hub: https://hub.docker.com/r/albertborsos/yii2-php/tags?page=1

You can check the final builds here: https://github.com/albertborsos/yii2-docker/actions/runs/4646430952

albertborsos commented 1 year ago

@schmunk42 I moved your updates from yii-docker to this PR. Thanks for your work!

schmunk42 commented 1 year ago

Thank you!

michaelarnauts commented 1 year ago

Not sure if this is related, but since this merge (and the newly published images), I can't seem to get an image from dockerhub.

$ docker pull yiisoftware/yii2-php:8.2-apache
8.2-apache: Pulling from yiisoftware/yii2-php
no matching manifest for linux/amd64 in the manifest list entries
schmunk42 commented 1 year ago

Meh, same here: https://github.com/yiisoft/yii-docker/issues/34

I am looking into it...

schmunk42 commented 1 year ago

@michaelarnauts

Should be fixed for amd64, but arm64 is gone :( I created a tag to re-add them.

Underlying issue: https://github.com/docker/bake-action/issues/58

@albertborsos Can an image with a different arch now be added in a push to Docker Hub?

michaelarnauts commented 1 year ago

awesome, thanks!

albertborsos commented 1 year ago

I tried it with with intel and silicon CPU-s, both works with my albertborsos/yii2-php images, which contains my first commit only.

So if we build and push it together, it works.

schmunk42 commented 1 year ago

What do you guys think about this solution? https://github.com/yiisoft/yii-docker/issues/34#issuecomment-1506826374