Connection class added (2.1.x)

yiisoft / yii2-elasticsearch

Yii 2 Elasticsearch extension

http://www.yiiframework.com

BSD 3-Clause "New" or "Revised" License

429 stars 252 forks source link

Connection class added (2.1.x) #301

Closed bizley closed 3 years ago

bizley commented 3 years ago

Q	A
Is bugfix?	yes
New feature?	no
Breaks BC?	no
Tests pass?	yes
Fixed issues	https://github.com/yiisoft/yii2/pull/18560

This fixes regression introduced in https://github.com/yiisoft/yii2/pull/18476

Should we create branch 2.0.x for previous versions of ES and push this change there as well to release v2.0.8? I don't see 2.0.x to be tested with Github workflow as well.

bizley commented 3 years ago

Oh, tests are expected to fail.

beowulfenator commented 3 years ago

I don't think we realistically need to update the 2.0.x branch of this extension.

samdark commented 3 years ago

Merged too early. See https://github.com/yiisoft/yii2/pull/18560

samdark commented 3 years ago

My fault with giving ✔️ review too early...