yiisoft / yii2-elasticsearch

Yii 2 Elasticsearch extension
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
427 stars 253 forks source link

Few updates to phpdoc, and add missing requirements to composer.json #308

Closed My6UoT9 closed 3 years ago

My6UoT9 commented 3 years ago
Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues
beowulfenator commented 3 years ago

Looks good, but why do tests fail?

samdark commented 3 years ago

@beowulfenator that's workflow cache issues, not ES failure.

samdark commented 3 years ago

Thanks.

samdark commented 3 years ago

They're fine. See build in master. It failed as well but differently. That's bad but not related to the pull request.