add search score results

yiisoft / yii2-elasticsearch

Yii 2 Elasticsearch extension

http://www.yiiframework.com

BSD 3-Clause "New" or "Revised" License

427 stars 253 forks source link

add search score results #312

Closed sobirjonovs closed 2 years ago

sobirjonovs commented 3 years ago

Q	A
Is bugfix?	no
New feature?	yes
Breaks BC?	no
Tests pass?	no
Fixed issues	no issue

yii-bot commented 3 years ago

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.

Could you supply us with a use case please? Please be as detailed as possible and show some code!

Thanks!

This is an automated comment, triggered by adding the label pr:missing usecase.

sobirjonovs commented 3 years ago

I needed it to get overall scores and each record scoring results in the elasticsearch result list.

samdark commented 2 years ago

Need a line for CHANGELOG and, ideally, some unit tests confirming behavior.

beowulfenator commented 2 years ago

I am rejecting this PR because it is not generic enough. If in the future somebody is inclined to make a proper implementation of this concept (i.e. a "track scores" flag in Command) they are welcome to do so.