search

yiisoft / yii2-elasticsearch

Yii 2 Elasticsearch extension
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
429 stars 252 forks source link

Added Runtime Mappings #313

Closed mabentley85 closed 2 years ago

mabentley85 commented 2 years ago
Q A
Is bugfix? no
New feature? yes
Breaks BC? no? Requires Elasticsearch version 7.11 or higher
Tests pass? yes

Added query config to support Runtime Fields/Mappings in Elasticsearch 7.11 and newer.

yii-bot commented 2 years ago

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

mabentley85 commented 2 years ago

I added a test based on the other tests I saw. Please let me know if I need to add more assertions or anything else. Also I added the latest version of Elasticsearch 7.14.0 to the GItHub action so that this feature can be tested.

mabentley85 commented 2 years ago

@beowulfenator This PR is ready for review, Thanks!

samdark commented 2 years ago

Looks alright to me. @mabentley85, would you please add a line for CHANGELOG and maybe some info for README and https://github.com/yiisoft/yii2-elasticsearch/tree/master/docs/guide?

mabentley85 commented 2 years ago

@samdark Thanks! I just added a note to the change log and some documentation to the query guide.

samdark commented 2 years ago

Thank you!