Closed terabytesoftw closed 2 years ago
We can do two jobs within the same github action it's quite simple, but i particularly like the separate jobs.
By the way, having both jobs does not mean that we will have duplicate code, we can make a reusable github action https://github.com/yiisoft/actions/blob/master/.github/workflows/phpunit.yml, the only thing we have to repeat is the service, since a limitation is that we cannot establish a condition to configure the env vars, within the service.
closed in favor https://github.com/yiisoft/yii2-elasticsearch/pull/323
I can do it in a single github action, but i think since the version is newer, i think it's convenient to keep it separate, i look forward to your comment.