yiisoft / yii2-jui

Yii 2 JQuery UI extension.
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
131 stars 114 forks source link

f.getClientRects is not a function #72

Closed sircovsw closed 6 years ago

sircovsw commented 7 years ago

What steps will reproduce the problem?

$("#qqq").dialog("open")

What's expected?

opens a dialog

What do you get instead?

f.getClientRects is not a function

Additional info

Q A
Yii vesion 2.0.13
PHP version 7.1
Operating system debian 8
giovaz94 commented 7 years ago

I confirm the error too,

This is a bug caused by the incompatibility between jquery ui 1.11.* and Jquery 3.x.x 3181

Yii2 should update the jui assets dependencies.

baldiri commented 7 years ago

Hi people,

same error as well. Let me ask a stupid question, who is responsable to update jquery to version 3?

thanks in advance!

cebe commented 7 years ago

If there is an incompatibility between jQuery and jQuery UI I would expect this to be reflected in version constraints of the jQueryUI bower package...

makroxyz commented 6 years ago

Any news about a fix?

samdark commented 6 years ago

Not yet.

darwinwen commented 6 years ago

This is the solution, need to be updated JQuery UI 1.11.4 to 1.12.1

https://stackoverflow.com/questions/37914869/jquery-ui-error-f-getclientrects-is-not-a-function

lubosdz commented 6 years ago

Also reported here: https://github.com/vanderlee/colorpicker/issues/132

Currently Yii2 (as of 2.0.13) vendor/bower/jquery-ui/bower.json loads 1.11.4, should be 1.12.1+. But probably all Yii2 JUI-* components should be tested ... (:-o)

Possible quickfix would be including migration script (https://code.jquery.com/jquery-migrate-3.0.0.min.js). See https://github.com/jquery/jquery/issues/3157.

nsanden commented 6 years ago

Migrate script does seem to fix the problem for now

thattejada commented 6 years ago

Same problem here when trying to add a Parent Menu with in the Yii2-admin menu module: screen shot 2017-11-20 at 2 18 26 pm When I type some parent menú this is the error: screen shot 2017-11-20 at 2 12 34 pm

IvanMakarenko commented 6 years ago

lubosdz, thx

P.S. Faster fix that please.

samdark commented 6 years ago

Pushed a commit to master. That should fix it.

tegaradam commented 4 years ago

don't how it works but migration script fix the problem

DavidAmorocho commented 2 years ago

migration script? what does this means?

don't how it works but migration script fix the problem

samdark commented 2 years ago

@DavidAmorocho no idea. The issue if fixed in latest version.