search

yiisoft / yii2-redis

Yii 2 Redis extension.
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
451 stars 184 forks source link

PHP 7.2 compatibility #127

Closed brandonkelly closed 6 years ago

brandonkelly commented 6 years ago
Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
samdark commented 6 years ago

7.2 should be added to .travis.yml in order to make sure it works well.

brandonkelly commented 6 years ago

@samdark done 👍

samdark commented 6 years ago

Tests do fail. This is additional case to be fixed where count() should be called on objects only.

brandonkelly commented 6 years ago

@samdark Fixed now, and Travis likes it.

cebe commented 6 years ago

Thank you!