search

yiisoft / yii2-redis

Yii 2 Redis extension.
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
451 stars 184 forks source link

fixed #166 #167

Closed razonyang closed 6 years ago

razonyang commented 6 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #166
yii-bot commented 6 years ago

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

razonyang commented 6 years ago

Added unit tests

samdark commented 6 years ago

Great! Now a line for changelog and that's it. Thanks!

razonyang commented 6 years ago

Changed CHANGELOG :)

samdark commented 6 years ago

Merged. Thank you!