search

yiisoft / yii2-redis

Yii 2 Redis extension.
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
452 stars 183 forks source link

Fix reconnect to Redis #177

Closed kshart closed 5 years ago

kshart commented 5 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? no
Fixed issues #176
samdark commented 5 years ago

@cebe would you please take a look?

rob006 commented 5 years ago

Tests are failing. And to be honest, these changes do not make any sense to me. And I don't understand problem reported in #176 - there are tests to verify retries support, if something is wrong with the behavior, we should start from changing tests to show what is wrong. Right now tests are passing on master and failing on this PR, so basically, this PR is breaking stuff :P.

kshart commented 5 years ago

@rob006 Hi, I do not know how to make service redis stop/start or ifdown/ifup in the test. The problem occurs when "operating system" breaks the link

cebe commented 5 years ago

This change does not solve the problem but moves it to another method making the direct method call unable to retry. I'm closing this pull request, the issue however is valid. See my comment there.