search

yiisoft / yii2-redis

Yii 2 Redis extension.
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
452 stars 183 forks source link

Connection::isActive() returns FALSE when the connection is active #216

Closed cornernote closed 3 years ago

cornernote commented 3 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? yes/no ?
Tests pass? yes/no ?
Fixed issues #215
yii-bot commented 3 years ago

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

cornernote commented 3 years ago

Hello,

Sorry guys, I'm not sure how to make unit tests and I don't have the time to learn right at the moment. Also the unit test would have to have a TLS redis connection available, further complicating the process of creating tests.

It's pretty clear what the bug is, and I can confirm the fix works. If you can put the unit tests into place that would be awesome.

Best regards, Brett

samdark commented 3 years ago

Alright. At least it didn't break existing tests. Please add a line for changelog.

samdark commented 3 years ago

Thanks!