search

yiisoft / yii2-twig

Yii 2 Twig extension.
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
136 stars 61 forks source link

fixed HtmlHelperExtension issue #122

Closed boliver20 closed 4 years ago

boliver20 commented 4 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #103
samdark commented 4 years ago

Seems to fail tests.

boliver20 commented 4 years ago

Seems to fail tests.

Yes, unfortunately, the code is not compatibility for Twig 2.7+. Maybe I put >=2.0 <2.7 restrict in composer.json?

boliver20 commented 4 years ago

Looks good. A line for changelog is needed.

Sorry, I added.

samdark commented 4 years ago

Merged. Good job 👍

I'm going to release 2.2.2 and then proceed with another pull request.