yiisoft / yii2

Yii 2: The Fast, Secure and Professional PHP Framework
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
14.23k stars 6.91k forks source link

Implement NoSQL Storage for ActiveRecord #11

Closed cebe closed 10 years ago

cebe commented 11 years ago

Will implement:

redis (versions >= 2.6) (pull request: #905 merged)

elastic search (pull request: #1295 merged)

mongodb (pull request: #1438 merged)

Sphinx (Pull Request merged)

http://sphinxsearch.com/

Other systems that may get implemented (suggestions welcome):

Other resources:

cebe commented 11 years ago

Btw the checkboxes in here are made like this: https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

oherych commented 11 years ago

Most noSQL databases have connection via REST. Will be greate have one defined interface for all Rest client. This give us able have one selected (by developer) REST library for all needs. We just say with which library it should use

Aoseala commented 11 years ago

Personal think elasticsearch PHP client, Elastica is very good! this is his github repository URL: https://github.com/ruflin/Elastica

ghost commented 11 years ago

You mentioned 2 of my yii extensions so I might share my thoughts/experiences on this issue here: The whole noSQL topic is far too complex to make a "one fits all" solution even possible (I've tried and failed :-) ). I wanted to make things easier with my ActiveResource extension but there are a lot of design flaws in there so it is a bad candidate for reviewing. My suggestion for Yii in this respect: Take a look at Guzzle which is a REST client framework. I takes care of the annoying parts (authentication, caching, asynchronous/parallel curl requests), is extensible via plugins and actively maintained. Yii could offer an interface on top of Guzzle so that there is a well defined API to develop against, maybe in combination with the repository pattern

DaSourcerer commented 11 years ago

As I see Guzzle being mentioned here: While Guzzle is indeed a formidable solution with facilities that make inclusion into Yii trivial, I'd like to advise caution. As mentioned before, it is not just a library but an entire framework. It would also introduce a hard dependency on libcurl (it is my impression that the original author simply wanted to spare himself from dealing with all the gory details of socket programming). Just saying :smirk:

rawtaz commented 11 years ago

This is almost getting a bit OT, but I have to say: +1 for the repository pattern. Been missing it in Yii a lot of times.

dmill-bz commented 11 years ago

I would love to see HyperDex in this list. I know this is a bit of a longshot but it's got good performance, supports ACID transactions and has strong consistency guarantees and fault tolerance to boot.

It's outperformed MongoDB, Cassandra, and I believe Redis in the YCSB (despite better consistency guarantees and fault tolerance). It's only downside really is that it's relatively young compared to other solutions.

Here are some links:

http://hyperdex.org/doc/ http://hyperdex.org/performance/ http://hyperdex.org/performance/details/ (more details regarding benchmark) https://github.com/tritondigital/php-hyperdex

Alternativly I could settle with MongoDB even though I'm uncomfortable with some aspects of the data storage (or non-storage in this case)

klimov-paul commented 11 years ago

Implement NoSQL Storage for ActiveRecord

I am not sure how exactly such implementation should look at the end. I can not see an universal solution for this. Different NOSQL storages use different approaches for the data storage and data structure. There are several types:

Key-value storages could match the original Yii model paradigm, which relies on architecture, when model has only (or at least mostly) scalar type attributes.

However document oriented storage does not fit the Yii model paradigm. In such storages (as MongoDb) the single storage entry is a huge nested JSON document, which can not be described by simple model with scalar attributes.

Graph oriented database (such as Neo4j) actually could fit the Yii model paradigm. However the search inside such storages is rather different from the common database. Here you are starting with some node and then go to the nodes related with it. Sometimes universal search criteria can not be composed for fetching particular node with the single query. But the main problem with such storages as Neo4j is they do not support PHP directly and there are no PHP drivers for them. Such storages can be accessed only via REST API.

cebe commented 11 years ago

@Haensel commented in https://github.com/yiisoft/yii2/issues/73#issuecomment-16884173: I don't know if it is still the case but if you are still planing to implement a mapper for graph databases (Neo4j, OrientDB etc.) I would suggest you to take a look at Tinkerpop Blueprints (https://github.com/tinkerpop/blueprints/wiki). From the wiki:

"Blueprints is analogous to the JDBC, but for graph databases. As such, it provides a common set of interfaces to allow developers to plug-and-play their graph database backend. Moreover, software written atop Blueprints works over all Blueprints-enabled graph databases."

Neo4j and OrientDb both support Blueprints and are the most widely used graph dbs, so it might be worth a look

cebe commented 11 years ago

In case you wonder where to find this: I'm on the redis branch: https://github.com/yiisoft/yii2/tree/redis

dmill-bz commented 11 years ago

Is there an interface or required functions for Connection class? I would like to implement support for Rexster (as per the tinkerpop comment earlier). I've already made a php client for RexPro (which part of is very similar to the Yii Connection.php). I'd like to use it as a helper as a first step even if it's redundant (because I might move on to making a php extension to support rexPro. I'm going to start now just trying to stick as much as possible to the current file/functionality.

cebe commented 11 years ago

Is there an interface or required functions for Connection class?

Will be there but I am not finished with that yet. Will define the interface or base class, when we have more dbms implemented so I'd be very interested in seeing your class.

dmill-bz commented 11 years ago

ok! I haven't gone very far yet. I've used your Connection class as a basis and have made one for Rexter. I've left out Transactions and the concept of Isolation (or non-isolation in this case which allows for queries to use bindings set by previous queries) because it will probably need a bit of discussion . I'll get onto looking into activeRecord and ActiveQuery classes next. Once I get ideas as to what to do about representation of Vertices vs Edges and routes and so forth. I'll probably post my suggestions. (I also should have a look at Neo4Yii to see how Hansael tackled it)

dmill-bz commented 11 years ago

ok having a look around. How would you suggest modifying get() and set() for shema-less db structures in activeRecord? This is kind of tricky as it'll catch all.

dmill-bz commented 11 years ago

graph DB and gremlin discussion for graph implementation here : http://www.yiiframework.com/forum/index.php/topic/43863-graph-databases-gremlin-qquery-building/ I reckon I should have something to push online by the end of the week depending on how the discussion goes. a preview version if you will

cebe commented 11 years ago

Sadly haven't had the time to go there, but there is some really interesting stuff at berlinbuzzwords conference this year http://berlinbuzzwords.de/ .

http://berlinbuzzwords.de/program/session-schedule/all

Sammaye commented 11 years ago

I don't mean to plug my own content here but: https://github.com/Sammaye/MongoYii can handle MongoDB in a schemaless manner and I have the intention of converting it to Yii2 as soon as a stable interface for its conversion is made.

Maybe a stripped down version of something like that could be used for core?

cebe commented 11 years ago

It's nothing bad about showing your own content when you think it is good. Looks really interesting, will definitifely take a look at it. Thanks for sharing!

dmill-bz commented 11 years ago

I've been very busy recently but finally shifted towards making Yii independent libraries for graph DBs. Mostly speaking a DB client for rexster and an equivalent of a QueryBuilder for gremlin. Now I'm concentrating on integrating these into Yii2. I was wondering where the correct place for external libraries to reside was? I've been sticking them in the helpers dir for now even though that didn't seem correct. Any help would be appreciated. Thanks

Sammaye commented 11 years ago

Normally, for better composer integration, many have taken to adding such things to a vendors folder. This pattern is, of course, also replicated in many languages including Java.

dmill-bz commented 11 years ago

Yeah, I couldn't seem to find one though. Doesn't matter, I'll place them there for now and move on. I'll move them around once I get a better idea.

jabbon commented 11 years ago

Support for MongoDB +1 (ActiveRecord, Sessions) Support for Redis +1 (Cache, Sessions)

cebe commented 11 years ago

Support for Redis +1 (Cache, Sessions)

@jabbon this is already implemented and available on master branch.

Support for MongoDB +1 (ActiveRecord, Sessions)

does it really make sense to store Sessions on MongoDB?

Sammaye commented 11 years ago

Yes, MongoDB, if done right, can store the session completely in working set, i.e. RAM just like redis

qiangxue commented 11 years ago

Suggest moving /db/redis to /redis because redis is relatively independent of the other classes under db.

cebe commented 11 years ago

The current classes are but the AR does extend from the db\ActiveRecord I think we should make a decision when redis an elasticsearch are ready.

qiangxue commented 11 years ago

By having redis directly under the framework folder, it's like making it a self-contained extension with dependency on Yii. Other directories under db mainly contain drivers which are not the same as redis.

cebe commented 11 years ago

Agree. Will make the move soon.

mcd-php commented 10 years ago

I vote for Apache Cassandra inclusion - it uses SQL-like language ( CQL ), has PDO driver, i made it work for my closed-source job project.

On the other side, my piece for it may be application-biased (or have some parts of application inside it), and ignorant of some framework guidelines. It's also ridden with backward-compatibility kludges, since i converted from Yii1 and from PHPCassa to PDO - two overhauls far before start ;).

So i it may be better if core team write their own, stumble upon all lack of dependency injection, and ask me questions if stuck. Or should i go over all my code and file issues on all stumbles i had to dodge ?

Anyway, i am willing to help with this.

qiangxue commented 10 years ago

It would be great if you could submit a PR for this, and we can work together to polish it (unless other @yiisoft/core-developers has experience with Cassandra and willing to work on this). Thanks.

cebe commented 10 years ago

I think we can close this issue now. I am done with all the system I know and can support as I am going to work with them on a regular basis. Others should be provided as extensions or by other core developers. If someone wants to start working on an implementation of an AR feel free to contact me, I can help with that.

qiangxue commented 10 years ago

This is a wonderful piece of work! Thank you, @cebe and @klimov-paul

cebe commented 10 years ago

:-)

basil-inc commented 10 years ago

great work guys, thanks!

Sammaye commented 10 years ago

I will probably start work on a Solr extension in a min, have need of one and it appears there isn't one yet when I search Google.

cebe commented 10 years ago

We decided to use elasticsearch in favor of solr, as it is much more powerful. But that shouldn't stop you from creating a solr extension :)

nineinchnick commented 10 years ago

I also use Solr and would help to write/test/review such extension.

Sammaye commented 10 years ago

I have just started on a Solr application component which extends from the Pear PHP Solr Client I have started here since I am still quite new to PHP coding in Solr (it is normally another guy who does it, I am an ES and Sphinx guy) but I wouldn't mind someone (like you or whatever) with the knowledge taking something like: https://github.com/phpnode/YiiSolr and making something pure awesome from it.

The idea is to eventually get to that but as I said, I am still a newbie to Solr but it is a requirement of my application so I have to port it over.

cebe commented 10 years ago

So what do you need to get started with it?

cebe commented 10 years ago

You may take the elastcisearch implementeation and mark all code that needs to be adjusted with todos. After that starting to implement connection and basic querying.

Sammaye commented 10 years ago

Yeah I think that's a good idea actually thanks

Sammaye commented 10 years ago

I will probably strip the ES code and then try and copy the Pear PHP client over, though not too much since that code is old and decreped so...yeah, just take the basic requirements of Solr (escape functions etc) and then build it into the rest that exists in ES code

rawtaz commented 10 years ago

There's http://www.solarium-project.org/ too. I haven't looked at the code of the PEAR extension you mentioned, but given how completely awful the majority of other PEAR extensions have been through the years I ever looked at them, perhaps this one is a cleaner code base to use for your implementation (assuming the license is compatible).

Sammaye commented 10 years ago

Ah yeah, that looks much better I'll take a look and see what I can with it, maybe use that as the base and the Yii2 classes as abstraction

On 25 April 2014 12:11, rawtaz notifications@github.com wrote:

There's http://www.solarium-project.org/ too. I haven't looked at the code of the PEAR extension you mentioned, but given how completely awful the majority of other PEAR extensions have been through the years I ever looked at them, perhaps this one is a cleaner code base to use for your implementation (assuming the license is compatible).

— Reply to this email directly or view it on GitHubhttps://github.com/yiisoft/yii2/issues/11#issuecomment-41381636 .

Sammaye commented 10 years ago

Wow that Solarium is pretty much a framework in itself

Sammaye commented 10 years ago

I am unsure if solarium project is fully compatible with Yii2.

It uses the symfony event dispatcher ( https://github.com/symfony/EventDispatcher ) which I don't think would be callable with Yii2's own events. Not only that but it isn't the lightest piece of code.

Anything built from it would require a lot of hacking in Yii2's internals to make sure Yii2 does not interferer with it.

Basically it will be more of a jerry rig if I build from that due to how complete it is. I will still try though I think, it has all of the functions etc that are needed, but then I might also be able to do these simpler if I coded from start and used the ES base

cebe commented 10 years ago

They should not interferre but there is the question of the need of a yii implementation when solarium has everything you need already. What is missing from solarium what a yii extension would bring?

Sammaye commented 10 years ago

Well I guess it is implementation with Yiis active record etc, I mean I don't really need that, only querying but I am sure others would

cebe commented 10 years ago

Is solr really used as a data storage as it is the case with elasticsearch? If it is not a common usage to create update and delete records in solr it may not be worth the effort of creating AR layer for it.

Sammaye commented 10 years ago

We were recomended by users on the Solr group to actually use Solr as a full data store when querying it, so our entire "books" table is duplicated across MySQL and Solr.

The reason we don't need Active record is because we are usng old code that relies on cronjobs to send xml files to Solr once every so often.

Thugh Solr is more of a search tech than a database...hmmm

On 25 April 2014 13:31, Carsten Brandt notifications@github.com wrote:

Is solr really used as a data storage as it is the case with elasticsearch? If it is not a common usage to create update and delete records in solr it may not be worth the effort of creating AR layer for it.

— Reply to this email directly or view it on GitHubhttps://github.com/yiisoft/yii2/issues/11#issuecomment-41387023 .