yiisoft / yii2

Yii 2: The Fast, Secure and Professional PHP Framework
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
14.23k stars 6.91k forks source link

dark background on error view when using dark theme #19271

Open nilsburg opened 2 years ago

nilsburg commented 2 years ago

What steps will reproduce the problem?

On the latest Google Chrome version when using a dark theme on the OS (Windows 10) it sets the default page color to black instead of white.

This makes the error page unreadable (look at the provided screenshots)

Setting the background color to white on the body element solves it. I could make a PR but I am not sure where the styles are located.

What is the expected result?

To see the error page with white background (using Windows 10 light theme): image

What do you get instead?

Using Windows 10 dark theme image

Additional info

Q A
Yii version 2.0.45
PHP version 7.4
Operating system Windows 10
Browser Google Chrome 98.0.4758.102

Funding

Fund with Polar

bizley commented 2 years ago

I'm not sure what is going here but did you put word dark before return and expect it to work?

bizley commented 2 years ago

Ohh, my bad, this is just to show the contrast, right?

nilsburg commented 2 years ago

Ohh, my bad, this is just to show the contrast, right?

Yes, I put the string dark on purpose to force the error page.

WinterSilence commented 2 years ago

error view use outdated highlightJs, need update library and theme