yiisoft / yii2

Yii 2: The Fast, Secure and Professional PHP Framework
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
14.24k stars 6.91k forks source link

MaskedInputAsset picking wrong name after update #20041

Closed mtangoo closed 12 months ago

mtangoo commented 1 year ago

What steps will reproduce the problem?

  1. Set composer to "yiisoft/yii2": "^2.0.49"
  2. Run Composer update
  3. use any widget that uses masked input like https://github.com/kartik-v/yii2-number/

What is the expected result?

Widget should work correctly

What do you get instead?

GET <URL>/assets/9a3e2b0/jquery.inputmask.bundle.js net::ERR_ABORTED 404 (Not Found)

Additional info

It seems somehow masked input version was changed and bower no longer installs jquery.inputmask.bundle.js but rather jquery.inputmask.min.js

Q A
Yii version 2.0.?
PHP version
Operating system
mtangoo commented 1 year ago

The problem is rather fixed in master but the current stable version is unusable for projects that depends on maskedInput widget. I cannot find yet the commit that introduced such change but we can find a way to fix only this issue and release new version to make it usable again

mtangoo commented 1 year ago

2.0.49.1 works fine, so the change seems to be introduced in 2.0.49.2

terabytesoftw commented 1 year ago

It's fixed in the master, the change was here.

https://github.com/yiisoft/yii2/pull/20009

bizley commented 1 year ago

https://github.com/yiisoft/yii2/issues/20013 @terabytesoftw Should we release 2.0.49.3 with all currently made changes to fix this?

terabytesoftw commented 1 year ago

yes

rob006 commented 1 year ago

I would rather revert https://github.com/yiisoft/yii2/commit/20a4b7eff9a4046a5c25bc206a8f085f2cab951c for 2.0.49.3. If 2.0.49.x is supposed to be LTS, then I would avoid such change in this line and keep it only in 2.0.50 (which will also increase required PHP version).

terabytesoftw commented 1 year ago

I would rather revert 20a4b7e for 2.0.49.3. If 2.0.49.x is supposed to be LTS, then I would avoid such change in this line and keep it only in 2.0.50 (which will also increase required PHP version).

good idea.

mtangoo commented 1 year ago

I agree with @rob006 No need to introduce any change for just js library

bizley commented 1 year ago

I've discussed some options to release 2.0.49.3 with only this revert, but we don't have a safe solution for it. What do you think about releasing all the things we have merged so far as 2.0.49.3?

rob006 commented 1 year ago

I think it is too much for a patch release. What do you mean by "we don't have a safe solution for it"?

mtangoo commented 1 year ago

but we don't have a safe solution for it

What about creating a tag to a commit same commit as 2.0.49.1 and just change version? That will reverse the issue as minor release as well as allow the release of current change to major version

bizley commented 1 year ago

Let's move to the discussion, I explained more there.

bizley commented 12 months ago

2.0.49.3 was released.