search

yiisoft / yii2

Yii 2: The Fast, Secure and Professional PHP Framework
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
14.24k stars 6.9k forks source link

debug module highlight #3851

Closed Ragazzo closed 8 years ago

Ragazzo commented 10 years ago

It would be good to have highlighting in debug module, not only for sql. This can be done by this repo, it also was noted by @cebe some time ago and he made it available through composer . Currently working on this one .

Ragazzo commented 10 years ago

Related with https://github.com/yiisoft/yii2/issues/838

cebe commented 10 years ago

related to #52

samdark commented 10 years ago

You mean debug module or general framework exceptions?

Ragazzo commented 10 years ago

@samdark ?

samdark commented 10 years ago

I was asking about "highlighting in debug module, not only for sql". Which parts do you mean exactly? Where do you plan to add highlighting to?

Ragazzo commented 10 years ago

well, in Events debug module panel, to highlight event that was raised (it would be simple VarDumper::dump), also i think that in other panels category should be highlighted, and some values that could be auto-recognized. On Request panel i think we can highlight values of key -> values pairs, so it will be easy to read and understand this settings. Overall ofcourse we should not use it too much ) I will also adjust current css for highlighting to much one from exception view, what do you think ? I think it will be good if we will have one style, at least for php.

qiangxue commented 10 years ago

I think we should fix #52 first.

Ragazzo commented 10 years ago

well, it depends on what should be fixed. Can you maybe clarify there some questions ? Because as i se now we have already implemented 3d party highlighter that is based on hljs, and also hljs is free, so we have server and client solutions. So it will be good to have some questions list to clarify things.

qiangxue commented 10 years ago

What questions are you referring to?

Ragazzo commented 10 years ago

none, i just asking of what questions or bugs or features should be fixed in #52 ? Or what does should fix #52 first mean ? Since we already have everything we need, not sure if we should create some internal component wrapper for 3rd party in this case.

qiangxue commented 10 years ago

Where is the fix for #52? Do you mean the highlighter in the debug module?

I think the highlighter should be a self-contained extension rather than within the debug module. Also, I'm not sure if hljs is the best choice. There are many 3rd party solutions. We should integrate a good one (I have no idea which is better myself).

Ragazzo commented 10 years ago

Ah, i see your point, you want one as a local extension like others, something similar to what is done for authclient extension with several auth classes and strategies. Fine, should i close this one ?

qiangxue commented 10 years ago

Yes. I think once such an extension is ready, highlighting the debug info is a natural thing to do.

Ragazzo commented 10 years ago

Ok, however will keep separated issue about highlighting debug module open. Yet it is similar to some issue with all debug module features, but can be used for particular debug module highlighting discussion.

yii-bot commented 8 years ago

Issue moved to https://github.com/yiisoft/yii2-debug/issues/122