search

yiisoft / yii2

Yii 2: The Fast, Secure and Professional PHP Framework
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
14.24k stars 6.91k forks source link

Debug toolbar is not shown on PHP errors #7616

Open cebe opened 9 years ago

cebe commented 9 years ago

The problem is that ErrorHandler does not use application view in this case: https://github.com/yiisoft/yii2/blob/master/framework/web/ErrorHandler.php#L220

But toolbar is only rendered on view end body event: https://github.com/yiisoft/yii2/blob/master/extensions/debug/Module.php#L122

@samdark do you remember why app view is not used on PHP error?

We might fix this by adding a similar event to the errorhandler.

samdark commented 9 years ago

I think it's a safeguard for the case when there's an error somewhere in View layer. Adding event seems like a good solution for it.

yii-bot commented 8 years ago

Issue moved to https://github.com/yiisoft/yii2-debug/issues/80

cebe commented 8 years ago

reopening as the fix needs a framework change.