search

yijingru / BBAVectors-Oriented-Object-Detection

[WACV2021] Oriented Object Detection in Aerial Images with Box Boundary-Aware Vectors
MIT License
466 stars 87 forks source link

Question about wrong implementation in decode_prediction() #131

Closed tae-mo closed 2 years ago

tae-mo commented 2 years ago

Thank you for providng the code.

If I understand the code correctly, I think there is a wrong implementation in the code.

In line 20 of func_utils.py, https://github.com/yijingru/BBAVectors-Oriented-Object-Detection/blob/11dad9aefab65f68f9330824980ee0c08bdb7234/func_utils.py#L20-L23

you calculated tl ~ br by subtracting the center point. But as you can see in your paper,

스크린샷 2022-07-29 오후 6 21 33

the center point has to be added, instead of being subtracted.

I would appreciate if you let me know if I got wrong.

Thanks!