yikjunxian / pe

0 stars 0 forks source link

contacts are allowed to be assigned to weddings happening on the same day #8

Open yikjunxian opened 1 week ago

yikjunxian commented 1 week ago

Alex Yeoh was allowed to be assign to both weddings 1 and 2 that are happening on the same day. Even if planning multiple weddings that occur on the same day is possible, it is unlikely that vendors are assigned to multiple weddings on the same day. If it was an unintentional mistake on planners' part, it could result in the wedding planner to not have a vendor for conflicted weddings on the day of the weddings.

image.png

image.png

nus-se-bot commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

adding of weddings on the same date is allowed

Adding a new wedding that is the same data as another wedding is allowed.

image.png

In this case 3 weddings of the same date of 12/12/2025 was allowed. However, as a wedding planner, it is very difficult and unlikely to be managing multiple weddings in a day. If a wedding planner is managing many weddings, they may forget the dates of weddings they are managing, hence may accidentally take on a new wedding from a client unknowingly, which could be disastrous if they did not intend to do so. Hence, perhaps the app got warn and even prevent users from adding weddings on the same date.


[original: nus-cs2103-AY2425S1/pe-interim#2351] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is possible for a user to want to record two weddings on the same day, for example a situation where two clients have scheduled their wedding on the same day. The wedding planner might not be continuing to plan both weddings, but would still want to have a record of this in PlanPerfect.

We feel that adding a date restriction would be overly restrictive, and would be classified as a feature flaw due to "overzealous input validation".

Severity of this issue should be low, as it does not affect normal operations of the app, and only appears in rare situations where user creates two weddings on the same day.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Assigning of vendors to weddings that fall on the same day is not the same issue as allowing users to add weddings on the same day.

  1. Even if the dev team states that weddings of the same date can be added to the app for recording purposes, the application should still prevent users from assigning a vendor to multiple weddings on the same day.
  2. The dev team also mentioned that their intent was for users to plan for a single wedding, out of those that fall on the same day, hence, in any scenario, vendors should only be assigned to a single wedding that the wedding planners intent to actually carry out.
  3. The implication of this issue (e.g. cross-booking) is also not the same as the implication of adding weddings of the same date. Hence these issues are not duplicates.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Quite certain that i did not misunderstand the behaviour of the application as assigning of vendors to multiple weddings on the same day is allowed as demonstrated in the original bug report. While this is the expected behaviour as implemented by the dev team, i disagree that this is the **correct** behaviour
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Assigning of vendors to multiple weddings on the same day has valid and significant implications like cross-booking.