search

yikoyu / vuetify-pro-tiptap

A Rich Text Editor (WYSIWYG) for Vue3 with tiptap & Vuetify.
https://yikoyu.github.io/vuetify-pro-tiptap/
MIT License
138 stars 19 forks source link

feature: Link extras #309

Closed SergkeiM closed 2 months ago

SergkeiM commented 3 months ago

Hi @yikoyu

Thank you for this package saved me a lot of time.

I think Link is missing some functionily:

  1. Unlink
  2. Target attribute
  3. Rel attribute

Based on this: https://github.com/yikoyu/vuetify-pro-tiptap/blob/154be3b24f7b4a7217f14b7938eb0d8dba0bf762/src/extensions/components/LinkActionButton.vue#L33

I see only href is used, is ok to create a PR to add more to link?

Note: I didn't figured out how to add Unlink functionility

From what I see this pacakge was heavily inspired by https://github.com/Leecason/element-tiptap

In element-tiptap they have used a different aproach to bubble menu, are you planning anything like that?

yikoyu commented 2 months ago

@SergkeiM Regarding the demand for link extras, you can check out this PR. https://github.com/yikoyu/vuetify-pro-tiptap/pull/312

SergkeiM commented 2 months ago

Hi @yikoyu

Whooha looks good, didn't expect it so fast, I was actuallly planning to contribute :)