search

yikoyu / vuetify-pro-tiptap

A Rich Text Editor (WYSIWYG) for Vue3 with tiptap & Vuetify.
https://yikoyu.github.io/vuetify-pro-tiptap/
MIT License
162 stars 24 forks source link

fix: augment `vue` rather than `@vue/runtime-core` #357

Closed danielroe closed 3 weeks ago

danielroe commented 3 weeks ago

For a while, in the Vue ecosystem we've been augmenting @vue/runtime-core to add custom properties and more to vue. However, this inadvertently breaks the types for projects that augment vue - which is (now?) the officially recommended in the docs way to augment these interfaces (for example, ComponentCustomProperties, GlobalComponents and so on).

This means all libraries must update their code (or it will break the types of the libraries that augment vue instead).

Here's an example of how the augmented types end up broken.

This PR is a small effort to ensure the ecosystem is consistent. For context, you can see that vue-router has moved to do this, as well as Nuxt.

yikoyu commented 3 weeks ago

:tada: This issue has been resolved in version 2.5.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: