yikuang / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

query disco#items returns disco#info #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. run-server.sh
2. connect to xmpp server using Adium (OS X)
3. right click on xmpp account, choose discovery browser (in Adium)
4. left click on "Google Prototype" (in Adium)
5. server responds with a disco#info instead of a disco#items

What is the expected output? What do you see instead?

INFO: received XMPP packet:

<iq type="get" to="wave.vostro.n" id="AMPurpleJabberNode11,"
from="test2@vostro.n/tlantic">
  <query xmlns="http://jabber.org/protocol/disco#items"/>
</iq>
Aug 16, 2009 7:05:33 PM
org.waveprotocol.wave.examples.fedone.federation.xmpp.WaveXmppComponent
sendPacket
INFO: sent XMPP packet: 
<iq type="result" id="AMPurpleJabberNode11," from="wave.vostro.n"
to="test2@vostro.n/tlantic">
  <query xmlns="http://jabber.org/protocol/disco#info"/>
</iq>

What version of the product are you using? On what operating system?

mercurial sources
changeset:   62:827b02b4fa82
date:        Tue Aug 11 13:14:15 2009 +1000
summary:     Update console client help message for undo

Please provide any additional information below.

XmppDisco.java:102

should be NAMESPACE_DISCO_ITEMS, not NAMESPACE_DISCO_INFO

  void processDiscoItemsGet(IQ iq) {
    IQ response = new IQ(IQ.Type.result);
    WaveXmppComponent.copyRequestPacketFields(iq, response);
    response.setChildElement("query", WaveXmppComponent.NAMESPACE_DISCO_INFO);
    component
        .sendPacket(response, false, /* no retry */ null /* no callback */);

  }

Original issue reported on code.google.com by david.c....@gmail.com on 17 Aug 2009 at 1:10

GoogleCodeExporter commented 9 years ago

Original comment by btkalman@gmail.com on 27 Aug 2009 at 8:32

GoogleCodeExporter commented 9 years ago
I'll have a fix for this this weekend. Good catch. 

Original comment by anthonybaxter@gmail.com on 28 Aug 2009 at 7:15

GoogleCodeExporter commented 9 years ago
Issue 43 has been merged into this issue.

Original comment by btkalman@gmail.com on 10 Oct 2009 at 11:58

GoogleCodeExporter commented 9 years ago
This is fixed on my clone (anthonybaxter-federation) and will be merged into 
the 
mainline in a few hours.

Original comment by anthonybaxter@gmail.com on 30 Oct 2009 at 3:54

GoogleCodeExporter commented 9 years ago

Original comment by anthonybaxter@gmail.com on 5 Nov 2009 at 6:00