yillkid / iota-swarm-node

IOTA Swarm node Reference Implementation
Other
12 stars 9 forks source link

IOTA Palantír Messaging (IPM) implementation #16

Closed yillkid closed 6 years ago

yillkid commented 6 years ago

This is a spike to implement IOTA Palantír Messaging (IPM)[1] in TangleID new_claim[2] and get_all_claims_in_channel[3] API commands. Just add the key "addr" and "next_addr" keys in new_claim API request body for enabling the function and use get_all_claims_in_channel to query all claims in one channel, refer the API mamual[2][3] or test script file "tests/tangleid/new_claim_ipm.sh", "tests/tangleid/get_all_claims_in_channel.sh" for detail. The other hand, one complete workflow demonstration could be found on here[4].

[1] https://blog.florence.chat/introducing-iota-palant%C3%ADr-messaging-ipm-c599ed6d2191 [2] https://hackmd.io/s/HJyzQvF1z [3] https://hackmd.io/s/ry-8g8nNQ [4] https://github.com/yillkid/TangleID-IPM-sample

jserv commented 6 years ago

Since you are implementing IPM, there should be an entry to technical description inside source tree.

jserv commented 6 years ago

Use Markdown syntax to describe what you managed to express in pull request body.

jserv commented 6 years ago

Also, I don't believe the complete implementation of IPM can be landed within the few lines of code.

jserv commented 6 years ago

@yillkid, you shall explain why this pull request was obsolete.

yillkid commented 6 years ago

Will create a new pull request after code refectory and new documentation.