yilozt / mutter-rounded

A window manager for GNOME, with rounded corners patch
https://aur.archlinux.org/packages/mutter-rounded/
GNU General Public License v2.0
556 stars 26 forks source link

Blurred Artifacts vs. Animation transitions #15

Closed nine7nine closed 2 years ago

nine7nine commented 2 years ago

Hi,

After playing around with your code, i noticed blurred window artifacts appear during animation transitions. The cause is that you are removing the blur effect in the function meta_window_actor_after_effects() -- which isn't the place to be doing that, imho, as removing the blur last looks really bad with slow animations OR more complicated animations, such as Magic Lamp or Burn My Windows extensions...

I have written a patch that moves removing blur out of meta_window_actor_after_effects() and into start_simple_effect() -- so that blur is removed before the transition starts. This looks much better. I then fixed the logic / code for the unminimizse case - so that the blur isn't applied until the unminimize effect is finished... (so hooked through; meta_window_actor_after_effects())

my patch is here; https://github.com/nine7nine/mutter/commit/f293b043dae1c367109a3c0f2209971dc2ee6f09

your mutter branch doesn't allow opening issues, so i opened one here - but i could do a pull request, if you like?

the only outstanding issue that i see is that the blur also shouldn't apply on new window until the window is mapped and visible, but i haven't gotten around to fixing that yet. however, that is slightly more minor and could be dealt with in another commit.

also, i could adjust the patch/commit (as needed) or change the commit message to your liking, before submitting a PR.

thanks. have a great day.

nine7nine commented 2 years ago

@yilozt - obviously with my revised patch merged; this can be closed. ;-)