yilozt / mutter-rounded

A window manager for GNOME, with rounded corners patch
https://aur.archlinux.org/packages/mutter-rounded/
GNU General Public License v2.0
556 stars 26 forks source link

Window borders are covered up by rounded corners #9

Open ashrude opened 2 years ago

ashrude commented 2 years ago

image a you can see, with discord (bottem left), lutris (top left), and firefox(top right), the border is cut off. I don't really know how any of this works, so idk if it could even be fixed, it just annoys me sometimes (though, non-rounded corners annoy me more)

(that's Nautilus in the bottom right, it already has rounded corners)

yilozt commented 2 years ago

The window borders of corners have been cut out. I am trying to redraw borders for the windows with rounded corners, but I can't find a way to get correct borders colors from gtk themes.

ashrude commented 2 years ago

Hmm, yeah, that seems tricky. I think you'd have to figure out what theme is being used, and you'd have to parse the theme. You could also read a config file, and have the user match the border

gregor160300 commented 2 years ago

I think there are 2 options here. The first is we need to figure out how mutter gets that color from the theme and we redraw it. The second is we figure out what the current theme is and where it is stored and then try to parse the color for the borders from it. I think the first option is preferable. I think a starting point might be mutter/src/ui/theme.c get_padding_and_border

owzim commented 2 years ago

Or: Remove (override?) the border from the Theme entirely, and and make it configurable in the window manager with a sane default. Like a 33% opaque black.

jonseppanen commented 2 years ago

Hard agree with owzim.

You are entirely overriding window borders anyway by making them rounded.

You are also allowing the user to set the border radius as well.

Let the user also set border width and color, all the same parts of the same code.

While we are at it, shadows too. Hell, allow a full custom css override if necessary.

Different colors for active/inactive border would also be good.