search

yiluyucheng / dnaMethyAge

Predict epigenetic age from DNA methylation data
39 stars 11 forks source link

I try to add a Li2018 Clock to this pacage #2

Open zd200572 opened 2 years ago

zd200572 commented 2 years ago

am I do this right?

zd200572 commented 2 years ago

https://doi.org/10.1289/EHP2773

zd200572 commented 2 years ago

239 CpGs， Chinese population

yiluyucheng commented 2 years ago

am I do this right?

Yes, you are doing good. But to be consistent with the rules to name the models, I think it's better to rename 'Li2018' as 'LiJ2018'.

zd200572 commented 2 years ago

am I do this right?

Yes, you are doing good. But to be consistent with the rules to name the models, I think it's better to rename 'Li2018' as 'LiJ2018'.

OK, thanks, but in this clock, there are three intercepts, how should I deal with this ?

yiluyucheng commented 2 years ago

I don't understand how do you have three intercepts, can't you combine them into a single intercept?

zd200572 commented 2 years ago

I don't understand how do you have three intercepts, can't you combine them into a single intercept?

This is because, according to the article, the intercept depends on population‘s location or race. maybe I can split it to three subClocks?