JavaScript error (some sites) - Githubissues

yimingliu / reverse-image-search-safari

Safari app extension for reverse image search

BSD 3-Clause "New" or "Revised" License

57 stars 6 forks source link

JavaScript error (some sites) #8

Closed gingerbeardman closed 4 years ago

gingerbeardman commented 5 years ago

TypeError: undefined is not an object (evaluating 's.endsWith')

https://github.com/yimingliu/reverse-image-search-safari/blob/5fb4fd6e6bc3c46c3a89788b0fec949fbfe1f0d8/ReverseImageSearch%20Extension/reverseimage-injected.js#L17-L22

Screen shot 2019-11-11 at 23 58 28

I think more checks needed around line 20.

Seeing this whilst I am developing on my localhost right now.

gingerbeardman commented 4 years ago

Fixed in https://github.com/yimingliu/reverse-image-search-safari/releases/tag/1.1a1