search

yin72257 / pe

0 stars 0 forks source link

Error saying addressbook is not valid when downloading excel #5

Open yin72257 opened 2 years ago

yin72257 commented 2 years ago

image.png

Steps to recreate:

  1. Download in folder
  2. Open the file
  3. Try to save again
  4. Error message pops up

Expected behavior: Message says excel is currently open rather than addressbook is invalid

nus-se-script commented 2 years ago

Team's Response

This issue is more about the error message phrasing, we don't think there is a functionality bug since it does not affect normal operation. The error message displayed does not say that addressbook.json is invalid per the title. Thanks for pointing it out though

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: Apologies. I rephrased the error message as is not valid because "check that addressbook is present" implied there was something wrong with the addressbook.json file. What I mean is that the error message should at least account for the excel being open as the user might not know that it will cause a bug. Thus, instead of implying that the addressbook might not be present, it might be better to have the error message say close your excel and try again instead. It does seem kind of weird as usually downloading or exporting files can be done with the old file being open.

I do think that instead of being a functionality bug it can be a feature flaw.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]