yingshansambi / qbb2023-answers

0 stars 0 forks source link

Week 3 Feedback #4

Open dtaylo95 opened 1 year ago

dtaylo95 commented 1 year ago

Python script that performs alignment based on user input

2.25/8

Exercise Points Possible Grade
Read in inputs 2 1.5
Initialize matrices 1 0.75
Populate matrices 2 0
Perform traceback 2 0
Write alignment to file 0.5 0
Print out alignment score and number of gaps in each sequence 0.5 0

DNA alignment file

0/0.5

AA alignment file

0/0.5

README.md with alignment score and number of gaps in each sequence for each alignment

0/1

Total: 2.25/10

Great start! There are a few minor issues with what you have so far:

For full credit you still need the following:

dtaylo95 commented 11 months ago

Regrade 12/6/2023

Almost perfect! I think there's just one minor issue with your traceback. Check your while condition for performing traceback: https://github.com/yingshansambi/qbb2023-answers/blob/faddee313d983474a824c7a6a0d512fed4d1d9dc/week3/week3homework.py#L66

We want to end traceback at the top left (cell [0,0]), but what happens if i or j reaches 0 before the other one does?

Otherwise, this looks great!

Current grade: 9.75/10