yingshansambi / qbb2023-answers

0 stars 0 forks source link

Week 6 Feedback #6

Open dtaylo95 opened 10 months ago

dtaylo95 commented 10 months ago

README.md with commands and analyses

2/2

Exercise Points Possible Grade
Commands for Step 1.1 0.33 0.33
Commands for Step 2.1 0.33 0.33
Commands for Step 3.1 0.33 0.33
Answer to Step 3.4 1 1

plotting.py script to produce plots

3.75/4

Exercise Points Possible Grade
Code to produce step 1.2 PC plot 1 1
Code to produce step 2.2 AFS plot 1 1
Code to produce step 3.2 Manhattan plots 1 0.75
Code to produce step 3.3 effect size boxplot 1 1

Very minor issue, but it looks like you're plotting ALL of your associations in your manhattan plots, rather than just the genotype associations. To clarify: when you run your GWAS, you include the top PCs as covariates in the regression (this is correct). But this means that you also get regression results for the covariates, not just the variants you're testing. Take a look at the TEST column in the .assoc.linear output file(s) of the plink --linear command to figure out which results you want to keep/plot.

Pretty plots

4/4

Exercise Points Possible Grade
Step 1.2 PC plot 1 1
Step 2.2 AFS plot 1 1
Step 3.2 Manhattan plots 1 1
Step 3.3 effect size boxplot 1 1

Grade

Total: 9.75/10

Great work! Just one very small issue remaining!

yingshansambi commented 9 months ago

Hi Dylan,

Hope you had a great Thanksgiving holiday! Here is my resubmission of the week 6 homework. Thank you so much for checking!

Best, Sam

dtaylo95 commented 9 months ago

Thanks Sam! I've updated your grade. Great work; there's only one very small issue you'll need to fix for a 10/10