search

yining / vim-rustcexplain

view `rustc --explain` from inside Vim
2 stars 2 forks source link

Use non-deprecated checkhealth syntax #1

Closed dundargoc closed 3 months ago

yining commented 5 months ago
  1. First of all, thank you for the PR and bringing to my attention of the depcrecation of the API's.
  2. One thing I forgot to mention is the support for vim-healthcheck plugin which brings the checkhealth features to vim by implementing the health#... functions. Unfortunately, it will be broken by this PR. I should have made it clear in the docs, it was an oversight and my apologies for it;
  3. Now that knowing the health#... funcs in neovim are deprecated, here are possible paths to take:
    1. check if running inside vim or neovim first, and invoke respective and up-to-date funcs;
    2. wait for and rely on fixes of vim-healthcheck until the deprecated funcs are dropped;
    3. only support neovim for checkhealth (i.e. merging this PR);
    4. drop the checkhealth support in this plugin.
  4. I will revisit it after some time and some more thoughts, and suggestions are always welcome.
dundargoc commented 5 months ago

It is completely up to you, this PR was as much a fix as it was for spreading awareness. I would personally probably drop vim healthcheck support as vim-healthcheck usage never really spread. It's basically not really used.

dundargoc commented 3 months ago

This PR should work as is, feel free to use it. I'm merely closing it as to not clutter my own PR page.