search

yinkakun / medusa-file-r2

13 stars 2 forks source link

Migrate aws-sdk v3 #4

Open cardoprimo opened 1 month ago

cardoprimo commented 1 month ago

Migrate to AWS-SDK v3 (https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/migrating.html)

yinkakun commented 1 month ago

Thank you for this improvement @cardoprimo

I noticed the diff was massive and that was because of conflicting formatting, I've added a prettier config now. Could you please fix the resulting merge conflict and run yarn format?

Also does migrating to aws-sdk v3 have any improvement in behavior compared to the current aws-sdk?

cardoprimo commented 1 month ago

Ok @yinkakun , I think that it should be better now. Let me know if anything else needed. Although, I have seen that Medusa V2 implements S3 compatible buckets natively already.

As far as I'm aware, the V3 behaviour is the same for this use case. I only noticed because of the warning that V2 is depreciated.