yipeeio / yipee

An opensource version of the Yipee.io editor.
Apache License 2.0
22 stars 7 forks source link

Applying just a service fails validation #20

Open jrryjcksn opened 5 years ago

jrryjcksn commented 5 years ago

importing this yaml

apiVersion: v1 kind: Service metadata: name: my-app namespace: my-namespace labels: app: my-app spec: type: LoadBalancer ports:

fails with {"success":false,"total":1,"data":["error: error validating \"/tmp/2bd1469e126f4ef0\": error validating data: ValidationError(Service): unknown field \"name\" in io.k8s.api.core.v1.Service; if you choose to ignore these errors, turn validation off with --validate=false\n"]}

Payload sent to apply {"flatFile":{"annotation":[{"type":"annotation","id":"28081e10-83b9-4f20-b8f7-16fe80818d50","key":"ui","value":{"canvas":{"position":{"x":287,"y":121}}},"annotated":"c49b09db-23b6-4fe8-aac4-62b889aeb462"},{"type":"annotation","id":"cbc27e14-0591-459c-8959-66e2efb74664","key":"ui","value":{"canvas":{"position":{"x":604,"y":180}}},"annotated":"f4f6c19a-bae0-4487-8207-a680faeea4f8"},{"type":"annotation","id":"8f32ee61-1373-4d71-a988-836585dcc94d","key":"description","value":"","annotated":"f4f6c19a-bae0-4487-8207-a680faeea4f8"},{"type":"annotation","id":"9459a42b-eee2-4a57-b10d-b797995eec99","key":"ui","value":{"canvas":{"position":{"x":629,"y":205}}},"annotated":"3977190e-477e-45ab-ab68-261b4fadf171"},{"type":"annotation","id":"8818e088-4c3a-462a-9696-343f83a58114","key":"description","value":"","annotated":"3977190e-477e-45ab-ab68-261b4fadf171"},{"type":"annotation","id":"05894b0b-77f1-40b7-8008-626af256dc8f","key":"override","value":"none","annotated":"3977190e-477e-45ab-ab68-261b4fadf171"}],"app-info":[{"type":"app-info","id":"00b2ff62-8d4a-4801-8da1-4ddb010f0820","description":"[insert app description here]","name":"justaservice"}],"container":[{"type":"container","id":"3977190e-477e-45ab-ab68-261b4fadf171","name":"redis","cgroup":"f4f6c19a-bae0-4487-8207-a680faeea4f8","position":-1}],"container-group":[{"type":"container-group","id":"f4f6c19a-bae0-4487-8207-a680faeea4f8","name":"asdf","source":"k8s","controller-type":"Deployment","containers":["3977190e-477e-45ab-ab68-261b4fadf171"],"container-names":["redis"]}],"deployment-spec":[{"type":"deployment-spec","id":"09160d2d-7128-4f44-b2cd-702afc168716","count":1,"mode":"replicated","cgroup":"f4f6c19a-bae0-4487-8207-a680faeea4f8","controller-type":"Deployment","service-name":"-- Select a service --","update-strategy":{"rollingUpdate":{},"type":"RollingUpdate"},"image-pull-secrets":[]}],"image":[{"type":"image","id":"e03061c4-1a10-4565-83cd-dd829d8ca8a2","container":"3977190e-477e-45ab-ab68-261b4fadf171","value":"redis"}],"label":[{"type":"label","id":"42c0b498-cfc2-43c5-b90d-fc487076b2ea","cgroup":"f4f6c19a-bae0-4487-8207-a680faeea4f8","key":"app","value":"my-app"}],"port-mapping":[{"type":"port-mapping","id":"1df26682-d0cd-42d7-9f5b-e0c0d28ac826","name":"http","svc-port-name":"http","container":"","external":"80","internal":"http","node-port":"","protocol":"tcp","container-references":false,"defining-service":"c49b09db-23b6-4fe8-aac4-62b889aeb462"}],"k8s-service":[{"type":"k8s-service","id":"c49b09db-23b6-4fe8-aac4-62b889aeb462","name":"my-app","metadata":{"name":"my-app","labels":{"app":"my-app"},"annotations":{}},"selector":{"app":"my-app"},"service-type":"LoadBalancer","cluster-ip":""}],"model-namespace":[{"type":"model-namespace","id":"e6750fc6-76b5-4509-9399-9d1779f663a7","name":"my-namespace"}],"service":[{"type":"service","apiVersion":"v1","kind":"Service","metadata":{"name":"my-app","labels":{"app":"my-app"}},"spec":{"type":"LoadBalancer"},"name":"my-app","id":"8701b71b-b52a-4723-9e29-9c13eeb72e35"}]}}

jrryjcksn commented 5 years ago

Even if we want to disallow this, the error message looks wrong.