search

yirano / drawFromAHat

A classic random name picker created by the help of the Github community.
https://yirano.github.io/drawFromAHat/src/
11 stars 16 forks source link

Allow user to continue picking name until every name has been picked. #19

Closed yirano closed 4 years ago

yirano commented 4 years ago

Allow the user to have the option to continue picking names until every name has been picked out.

MohamedYasser97 commented 4 years ago

I think I can start working on this too, I still have time😀

yirano commented 4 years ago

@MohamedYasser97 Before you start on this next one, could I ask if you've registered for Hacktoberfest2019?

yirano commented 4 years ago

This would be your fourth pull, and if you were registered you'll be meeting the requirements for their coveted shirt after this!

yirano commented 4 years ago

**Also to add to this further,

allow the names to be displayed in the order that it was picked to the right side of the page.**

MohamedYasser97 commented 4 years ago

@yirano Indeed I've registered for Hacktoberfest2019 but this would be my third PR not the 4th. However, I still want to help after my 4th PR. Before this one I've only made one PR in 2017 which I don't even remember doing so this project is my first real contribution to anything 😀

yirano commented 4 years ago

@MohamedYasser97, ah, forgive me. You've just been working so fast that I'm getting ahead of myself. Well I'm a little jealous! I haven't started a single PR yet. 😆

MohamedYasser97 commented 4 years ago

@yirano You just need to dig a little deeper for sad abandoned projects 😂. Anyway I can't thank you enough because now I'm getting the hang of all of this contribution routine.

yirano commented 4 years ago

You kidding me? I can't thank YOU enough!