search

yiransherry / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open Tooconfident opened 7 years ago

Tooconfident commented 7 years ago

Great job! You show a solid understanding of using <div> containers and classes vs. ids. Both your html and CSS look very solid and I don't have any major things to change. Visually your website is presented well, just go ahead and do a quick proofread for minor spelling and grammar errors. To expand on my note for the span's to have a class name, check out this article:

https://css-tricks.com/why-use-classes-or-ids-on-the-html-element/

Also though it is great that you show knowledge of child elements, programmers like to see classes or id's styled directly in the css, it just looks cleaner, is easier to read, and makes it easier for others reading your code to locate the section being styled when jumping from your CSS file to the html. Keep up the good work!

yiransherry commented 7 years ago

Thank you so much for the feedback! Really appreciated!