search

yireo-joomla / pkg_scriptmerge

GNU General Public License v3.0
7 stars 10 forks source link

Update simple3.php #13

Closed Morron-by-nature closed 8 years ago

Morron-by-nature commented 8 years ago

This one selects multiple parentheticals like ( abc(/nn/('/xvx/'))"// testing line") and protect them between colons as non comments. The other one did single pair parentheticals ones like ("/HGF/") So this one is better! By mistake used the single pair one at cleanup from file! They work to with all test lines but multiple finds more! but maked no differents to result of mine test code but it will in other casses. Made big changes to this simple code less sentenses and work 100% now on test code.. and added better compresion more save to..

Morron-by-nature commented 8 years ago

Hi Jisse wanted to finish my code so here it is! its smaller and better now!

yireo commented 8 years ago

A little bit scary to replace so many lines of code at once. Note that your addition is not in compliance with Joomla coding standards. I'll fix this, but you might want to see how you can setup your code editor to allow for the Joomla coding standards to be implemented. Developers will like you for it.