search

yireo-joomla / pkg_scriptmerge

GNU General Public License v3.0
7 stars 10 forks source link

Update helper.php #2

Closed Morron-by-nature closed 9 years ago

Morron-by-nature commented 9 years ago

Hi Yisse, Updated first case simple code REGEX for Compression. This code works on 6 million lines of Javascript code 900.000 Lines of comments. I am aiming for 100% It is running on www.heijer-onderhoud.nl I notist that there is no install XML file in your Pagage?

yireo commented 9 years ago

Thanks for this input. I've merged the PR, but will need to look into things anyway. The code compliance of ScriptMerge was not yet adapted to the Joomla Coding Standards, but I can see that your code isn't either. I also see there are a lot of more lines added. This requires a rewrite of the logic of ScriptMerge, so that perhaps a subclass is called (instead of using the main helper) for each compression technique. I will work on this soon, and only after that is done, a new version can be released to share this with the crowd.

As for the XML file: The packages on our Yireo site are working and setup properly. This GitHub repository is not meant to deliver installable packages, because that would also suggest that all other parts of extension offering (support, FAQ, documentation) are offered on GitHub - they are all offered on our main site. GitHub is used for code collaboration.

Morron-by-nature commented 9 years ago

Thanks very nice of you I now nothing about joomla standaards and programming trying to learn but I am a bit slow anyway thank for your responce!

Verzonden vanaf mijn Sony Xperia™-smartphone

---- Yireo schreef ----

Thanks for this input. I've merged the PR, but will need to look into things anyway. The code compliance of ScriptMerge was not yet adapted to the Joomla Coding Standards, but I can see that your code isn't either. I also see there are a lot of more lines added. This requires a rewrite of the logic of ScriptMerge, so that perhaps a subclass is called (instead of using the main helper) for each compression technique. I will work on this soon, and only after that is done, a new version can be released to share this with the crowd.

As for the XML file: The packages on our Yireo site are working and setup properly. This GitHub repository is not meant to deliver installable packages, because that would also suggest that all other parts of extension offering (support, FAQ, documentation) are offered on GitHub - they are all offered on our main site. GitHub is used for code collaboration.

— Reply to this email directly or view it on GitHub.