yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

Call to a member function getTypeId() #106

Closed colorfabb closed 5 years ago

colorfabb commented 5 years ago

Installed Yireo_GoogleTagManager-1.6.2 on Magento ver. 1.9.4.1 Frontpage goes blank with error:

Fatal error: Call to a member function getTypeId() on null in app/code/community/Yireo/GoogleTagManager/Block/Product.php on line 49

jissereitsma commented 5 years ago

I have just tested this in various environments and fail to reproduce this. Did you create theming overrides of the extension files? If so, what kind of changes did you make where?

colorfabb commented 5 years ago

JIsse,

We uploaded only the new files and overwrite the previous tag manager files. No custom overrides. I can sent you ftp of test .

Van: Jisse Reitsma notifications@github.com Verzonden: Thursday, June 13, 2019 9:56 PM Aan: yireo/Yireo_GoogleTagManager Yireo_GoogleTagManager@noreply.github.com CC: Hans Werps | colorFabb BV h.werps@colorfabb.com; Author author@noreply.github.com Onderwerp: Re: [yireo/Yireo_GoogleTagManager] Call to a member function getTypeId() (#106)

I have just tested this in various environments and fail to reproduce this. Did you create theming overrides of the extension files? If so, what kind of changes did you make where?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yireo/Yireo_GoogleTagManager/issues/106?email_source=notifications&email_token=ADCWDINZFEUVXO2ZWMH5NQ3P2KQ3XA5CNFSM4HXZCPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXU3KPQ#issuecomment-501855550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADCWDIN6CDG643MZ72ETJC3P2KQ3XANCNFSM4HXZCPPA.

With kind regards,

Hans Werps | colorFabb BV

[http://colorfabb.com/skin/frontend/ultimo/default/images/logo.png]http://www.colorfabb.com/

Bremweg 7 | 5951 DK Belfeld | Tel : + 31 (0)77 - 466 40 15 | Fax: + 31 (0)77 397 14 14 www.colorfabb.comhttp://www.colorfabb.com/ | h.werps@colorfabb.com

Take a look at our cataloguehttps://catalogue.colorfabb.com/

[colorfabb color on demand] https://colorfabb.com

jissereitsma commented 5 years ago

Unfortunately, I lack the free voluntary time to start debugging your custom site via FTP. For now, I'm not sure what could cause this issue. Nobody else reported this issue yet. The error that you get seems to suggest that the Product class is used in a place where it was not expected, most likely because some other extension is causing this to happen. However, somebody needs to jump and spend time analyzing this specifically on your site, as long as this is only happening on your site and not everybody else's site. It seems more an issue with your custom modifications (extensions, themes) than a general issue with this extension.

colorfabb commented 5 years ago

Jisse,

Too bad , disabled all non default extensions and switched to default theme. Still same error.

Van: Jisse Reitsma notifications@github.com Verzonden: Friday, June 14, 2019 12:24 PM Aan: yireo/Yireo_GoogleTagManager Yireo_GoogleTagManager@noreply.github.com CC: Hans Werps | colorFabb BV h.werps@colorfabb.com; Author author@noreply.github.com Onderwerp: Re: [yireo/Yireo_GoogleTagManager] Call to a member function getTypeId() (#106)

Unfortunately, I lack the free voluntary time to start debugging your custom site via FTP. For now, I'm not sure what could cause this issue. Nobody else reported this issue yet. The error that you get seems to suggest that the Product class is used in a place where it was not expected, most likely because some other extension is causing this to happen. However, somebody needs to jump and spend time analyzing this specifically on your site, as long as this is only happening on your site and not everybody else's site. It seems more an issue with your custom modifications (extensions, themes) than a general issue with this extension.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yireo/Yireo_GoogleTagManager/issues/106?email_source=notifications&email_token=ADCWDIMHM2WW4C2HZ2GI4HTP2NWTLA5CNFSM4HXZCPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWMPXA#issuecomment-502056924, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADCWDIJ4MP2CP622LIDRCCLP2NWTLANCNFSM4HXZCPPA.

With kind regards,

Hans Werps | colorFabb BV

[http://colorfabb.com/skin/frontend/ultimo/default/images/logo.png]http://www.colorfabb.com/

Bremweg 7 | 5951 DK Belfeld | Tel : + 31 (0)77 - 466 40 15 | Fax: + 31 (0)77 397 14 14 www.colorfabb.comhttp://www.colorfabb.com/ | h.werps@colorfabb.com

Take a look at our cataloguehttps://catalogue.colorfabb.com/

[colorfabb color on demand] https://colorfabb.com

dh1984 commented 5 years ago

I got the same error, then i update the module to version 1.6.3 and now its works all :)

jissereitsma commented 5 years ago

@dh1984 Thanks for reporting this back.

@colorfabb I will close this issue, because as of yet, it wasn't reproduced by myself and it also seems to be related to an outdated version.