search

yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

Unify Config Reading #14

Closed sprankhub closed 8 years ago

sprankhub commented 8 years ago

You have quite similar methods for reading the config in Yireo_GoogleTagManager_Helper_Data as well as in Yireo_GoogleTagManager_Block_Default. This should be unified. I suggest keeping it in the helper and call the helper methods from the block.

yireo commented 8 years ago

Sigh, legacy code. Good point. I will look into this soon (but am busy with too many things at this moment) and will leave this issue open until it is fixed.

yireo commented 8 years ago

Done