search

yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

Fixed Possible SQL Error #23

Closed sprankhub closed 8 years ago

sprankhub commented 8 years ago

$searchListBlock->getSortBy() may return an empty string or null, which breaks the SQL (resulting in a fatal error!). The order should only be set if it is available. Similar to Yireo_GoogleTagManager_Block_Category::getProductCollection.

jissereitsma commented 8 years ago

Awesome, thanks. It looks like a solid fix. Will see if I can build a new release soon.