search

yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

No SKU and brand added "twice" in product data layer #53

Closed mikebranderhorst closed 7 years ago

mikebranderhorst commented 7 years ago

https://github.com/yireo/Yireo_GoogleTagManager/blame/master/source/app/design/frontend/base/default/template/googletagmanager/data/product.phtml#L69 https://github.com/yireo/Yireo_GoogleTagManager/blame/master/source/app/design/frontend/base/default/template/googletagmanager/data/product.phtml#L71

The product dataLayer is missing the SKU and brand is added twice in the productData array.

jissereitsma commented 7 years ago

Thanks. This is a PR I accepted a long time ago, did not properly check and it seems to have a lot of weird stuff. It is fixed now.