yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

Add Event tags to Datalyer pushes #68

Closed grantkemp closed 5 years ago

grantkemp commented 6 years ago

Currently the datalayer pushes are not using events

This is generally considered bad practice, also prevents the data easily being reused for other purposes and most importantly improves the ability to debug the implementation.

eg productdetail should be

dataLayer.push({'event':'prodDetail', ecommerce: <ecom object>})

Other events could be

Its important that the above events aren't similar to the magento events used in their Enterprise commerce tag manager implementation- hence I suggested above to make sure they are different enough.

jissereitsma commented 5 years ago

Closing due to inactivity