A formated price is invalid in number_format, must be float

yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)

Open Software License 3.0

56 stars 46 forks source link

A formated price is invalid in number_format, must be float #78

Closed mikebranderhorst closed 6 years ago

mikebranderhorst commented 6 years ago

Warning: number_format() expects parameter 1 to be float, string given in app/design/frontend/base/default/template/googletagmanager/data/product.phtml on line 70

$this->getModuleHelper()->getProductPrice($product)

Returns: <span class="price">€ 123,00</span>

It should be float: 123.00

jissereitsma commented 6 years ago

Could you create a Pull Request for this? It actually offers less work than raising an issue ....

jissereitsma commented 6 years ago

https://github.com/yireo/Yireo_GoogleTagManager/commit/3c1c9b06e924e24424e6bdc322a118f30afac444