search

yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

Configurable Items added to data layer on order #9

Closed simonrl closed 8 years ago

simonrl commented 8 years ago

When ordering a configurable product (for example, T-Shirt size M), both products (configurable & simple) are added to the data layer in the success page which gives wrong ecommerce tracking data in GA. I am using the latest version (installed about 30 minutes ago).

The fix is simple: change Block/Order.php line 21 to:

if( $item->getParentItemId() ) {
    continue; 
}
yireo commented 8 years ago

Thanks. This sounds like a solid solution. Could you create a Pull Request for this (which is actually what most of the magic of GitHub is about)? Then I'll include it right away.

simonrl commented 8 years ago

done https://github.com/yireo/Yireo_GoogleTagManager/pull/10

yireo commented 8 years ago

Awesome. PR is merged. This Monday we'll pick up on a new release as well for MagentoConnect. Thanks again!