search

yireo-magento1 / Yireo_GoogleTagManager

Implement Google Tag Manager in Magento 1 (deprecated)
Open Software License 3.0
56 stars 46 forks source link

Fix number_format for correct thousands support #97

Closed popovserhii closed 6 years ago

popovserhii commented 6 years ago

Now the module format correct price only for hundred (245.00) but when the price is in thousands, such as 2457.00 it will be formatted to 2,457.00 and Google Analytics recognizes it as 2,46. This moment is described in Analytics documentation

A decimal point can be used as a delimiter between the whole and fractional portion of the currency. The precision is up to 6 decimal places. The following is valid for a currency field: 1000.000001.

This PR fixes this problem.

jissereitsma commented 6 years ago

Nice find. I will merge this so it is included in the next release!