yireo / Yireo_LinkPreload

Magento 2 extension to set HTTP Link headers for primary resources to allow for HTTP/2 Server Push
Open Software License 3.0
74 stars 18 forks source link

Link in headers can lead to page not loading #35

Closed Quazz closed 2 years ago

Quazz commented 2 years ago

When you have loads and loads of links to be preloaded on a page, this can lead to the page not loading due to it hitting "header size" limits (will say something about premature end to script in PHP error logs)

This can occur on a page by page basis.

Possible solutions:

Relevant function:

https://github.com/yireo/Yireo_LinkPreload/blob/563c99e1b17c6659d0daa87c133397bf68bb07a8/Link/LinkParser.php#L81

jissereitsma commented 2 years ago

Thanks for the PR. Fix is included in https://github.com/yireo/Yireo_LinkPreload/blob/master/CHANGELOG.md