Error parsing link header (Unexpected character "/" at offset 0)

[Morgy93]

Hello,

the Google lighthouse reports an error with the header link data:

There were issues affecting this run of Lighthouse:

Error parsing link header (Unexpected character "/" at offset 0): /static/version[....]/css/styles.min.css, /static/version…

The current format is like: Link: /static/version/.../css/styles.min.css, /static/version/.../js/whatever.min.js

My research says that it should look like: Link: <url>; rel="relationship-type"

So in my example: Link: </static/version/.../css/styles.min.css>; rel="stylesheet", </static/version/.../js/whatever.min.js>; rel="script"

[jissereitsma]

Did you make a patch of this and re-run the Lighthouse scan?

Currently, the only place where a header is added by this extension is here: https://github.com/yireo/Yireo_LinkPreload/blob/master/Link/Link.php#L64 And that's according to the specs...

[Morgy93]

Did you make a patch of this and re-run the Lighthouse scan?

Currently, the only place where a header is added by this extension is here: https://github.com/yireo/Yireo_LinkPreload/blob/master/Link/Link.php#L64 And that's according to the specs...

Interesting, that code you linked is never executed.

It's the processHeaders(): https://github.com/yireo/Yireo_LinkPreload/blob/1.4.21/Link/LinkParser.php#L81

There it just collects the links as array and adds them with implode() using , as seperator. Just like my initial description.

[jissereitsma]

This is a big fail of the code. I'm not sure where this went wrong, but definitely a sidetracking of the original HTTP specs is part of this. A fix is underway, including also the right integration tests to make sure this doesn't break anymore.

[jissereitsma]

Version 1.4.22 should fix this.

[Morgy93]

Version 1.4.22 should fix this.

Yes, it fixes it. Thanks!

Closed~