search

yireo / Yireo_NextGenImages

44 stars 26 forks source link

MISSING FILES #1

Closed CarlRonquillo closed 3 years ago

CarlRonquillo commented 3 years ago

Class Yireo\NextGenImages\Image\UrlReplacer does not exist Class Yireo\Webp2\Browser\BrowserSupport does not exist (got this file from the release 7.7 version)

jissereitsma commented 3 years ago

Thanks for reporting this and sorry for the mess. Could you see if version 0.0.4 is now fixing things for you?

CarlRonquillo commented 3 years ago

Thank you for responding.

Unfortunately, now this classes is missing. Class Yireo\Webp2\Browser\BrowserSupport does not exist Class Yireo\Webp2\Image\UrlReplacer does not exist

jissereitsma commented 3 years ago

@CarlRonquillo Could you mention your versions of both the WebP 2 module (which should be 0.9.2) and the NextGenImages module (which should be 0.0.4)?

CarlRonquillo commented 3 years ago

Yes that's the versions I'm using. I install it via composer.

jissereitsma commented 3 years ago

Thanks. Could you copy and paste the output of the following commands here in this issue?

composer show | grep yireo
grep -r Browser vendor/yireo/magento2-next-gen-images
grep -r Browser vendor/yireo/magento2-webp2
CarlRonquillo commented 3 years ago

image

Please note that I made it work, by copying some of the files from your webp2 8.0 release.

jissereitsma commented 3 years ago

Thanks. But we might be troubleshooting an old issue. Could you try upgrading to WebP2 version 0.9.3 and NextGenImages 0.0.4?

CarlRonquillo commented 3 years ago

OK i'll try.

CarlRonquillo commented 3 years ago

image

still got this issue on your latest versions

jissereitsma commented 3 years ago

I'm noticing something that I overlooked before: Are you sure that you are making use of composer? Because a simple composer update will update all files to their latest version. Because composer takes care of dependency loading, I definitely can not recommend not to use composer. The error deals with a file in app/code in a namespace Nineteen02?

CarlRonquillo commented 3 years ago

Yes, I've used composer in installing your modules. But the App/code/Nineteen02 that you are seeing is just my rewrite for the module.

If you look closely to your repository, you cannot see any Browser directory. It's really missing

image

CarlRonquillo commented 3 years ago

Or do you change it to Yireo_NextGenImages/Browser ?

CarlRonquillo commented 3 years ago

image

jissereitsma commented 3 years ago

Yes, there have been many changes in both extensions. I would not recommend you to build your extension on top of this, because there are no API extension points (service contracts, events, etcetera). What is the reason you have built your extension on top of this?

My first goal would be to see if the Yireo extension works for you or not. Let's close that issue afterwards. And then let's open a new issue on how you can create a new extension on top of Yireo WebP2.

jissereitsma commented 3 years ago

I'm closing this now because of inactivity, and because no one else run into issues with newer releases. Feel free to re-open if this same issue is still bugging.