While working on a plugin to integrate this module with Magento's RemoteStorage, we'd like to propose a few changes to increase the flexibility for such inheritance.
By using Filesystem $filesystem, a module can link this constructor parameter by their standard way:
For the private properties, only the $fileDriver itself is most likely to be needed, hence the change from private to protected. With these changes the integration works correctly, although we're still in the process of testing the different features (most importantly the direct conversion on upload).
While working on a plugin to integrate this module with Magento's RemoteStorage, we'd like to propose a few changes to increase the flexibility for such inheritance.
By using
Filesystem $filesystem
, a module can link this constructor parameter by their standard way:For the private properties, only the
$fileDriver
itself is most likely to be needed, hence the change fromprivate
toprotected
. With these changes the integration works correctly, although we're still in the process of testing the different features (most importantly the direct conversion on upload).