search

yireo / Yireo_NextGenImages

44 stars 26 forks source link

Webp conversion on category pages #37

Closed RickvanB closed 4 months ago

RickvanB commented 1 year ago

Hi,

I've been looking through the code, but I don't think it's possible to convert jpg/png images on the category overview pages? Is this something that's still on the roadmap or easy to implement by myself?

Thanks in advance.

jissereitsma commented 1 year ago

I'm a bit confused. The module does not do anything specific on category pages and in all of the environments I have seen so far, category pages contain images that are properly converted. Which code did you go through to make you make such a conclusion? Could it be that you are trying to address a specific issue in a specific environment that you are customizing?

RickvanB commented 1 year ago

Hi @jissereitsma,

We are working on performance improvements and we noticed that images on category/POP pages are not converted. Tools like Google pagespeed also complain about the fact that images are not in webp format for example. I looked at the code and came to that initial conclusion. Is it also possible to convert images via the pagebuilder?

jissereitsma commented 1 year ago

If you could point me to the code that you think is causing issues, please do. But as of yet, there is no specific issue reported by you, so I'm unable to be of use.

As for PageBuilder, no there is no ability to convert images. That's also not needed. PageBuilder simply spits out HTML & CSS. That HTML & CSS could contain img tags. Those img tags are then converted by this extension. If the conversion is not done, let's talk about that specific HTML.

RickvanB commented 1 year ago

I didn't pinpoint an issue just yet, because I was not sure if it converted images on certain places yes or no.

So to clarify, the module does not convert images that are placed within (dynamic) blocks, widgets and CMS pages? We also use the Mageplaza lady load module, which also adds a few classes to images (mplazyload mplazyload-transparent)

jissereitsma commented 1 year ago

You are asking about things but running in circles: Yes, the module is replacing images in any type of HTML on any type of page, regardless of the content. There are no exceptions for whatever you name as blocks, widgets and CMS-pages: Those are just backend concepts that are generating HTML. This extension does not care about the backend concepts, it cares about the HTML.

I'm going to keep my eye off of this topic for a while, because it seems that either I would jump to the rescue and start thinking along the lines of fixing the project, or you need to come up with details. Without details, there is nothing I can do.

What is the HTML? Show me the code. Let's not talk in theory. Let's talk code.

Disable the Mageplaza module.

jissereitsma commented 4 months ago

I'm closing this ticket due to inactivity.